fix: shutdownAsync flushes the whole queue

[marandaneto]

Problem

If the queue is bigger than flushAt after all pendingPromises are resolved, some events can still be lost since flush caps to flushAt anyway.
Discussed here with @benjackwhite #177 (comment)

Changes

Instead of calling shutdownAsync twice, we call until the queue is empty.

Release info Sub-libraries affected

Bump level

• Major
• Minor
• Patch

Libraries affected

• All of them
• posthog-web
• posthog-node
• posthog-react-native

Changelog notes

• Added support for X

[github-actions]

Size Change: 0 B 🆕

Total Size: 0 B

_{compressed-size-action}

[marandaneto]

will silently break instead of throwing an error or something since its an intended behavior.

[benjackwhite]

Other than a nit - love it!

[marandaneto]

Relates to jestjs/jest#14741 (comment) otherwise I cannot run tests locally

[marandaneto]

@benjackwhite there's just one test failing but its unrelated to my changes I guess.

FAIL posthog-node/test/feature-flags.spec.ts
● match properties › with relative date operators: is_date_before, 1h, 2022-05-01 00:00:00

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  2040 |   ])('with relative date operators: %s, %s, %s', (operator, value, date, expectation) => {
  2041 |     jest.setSystemTime(new Date('2022-05-01'))
> 2042 |     expect(matchProperty({ key: 'key', value, operator }, { key: date })).toBe(expectation)
       |                                                                           ^
  2043 |
  2044 |     return
  2045 |   })

  at posthog-node/test/feature-flags.spec.ts:2042:75

Could it be because of #189 (comment) ?

edit: it was probably flaky since its green now

[neilkakkar]

oh indeed, much better, thank you!