Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix bundle checker #203

Merged
merged 8 commits into from
Mar 9, 2024
Merged

chore(ci): fix bundle checker #203

merged 8 commits into from
Mar 9, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Mar 8, 2024

spotted the bundle checker wasn't actually checking anything

RN outputs a lot of files,
posthog-node do we care?

fixed the checker and restricted it to only posthog-web

Screenshot 2024-03-08 at 19 42 27

Verified

This commit was signed with the committer’s verified signature.
pauldambra Paul D'Ambra
@pauldambra pauldambra force-pushed the chore/bundle-checker branch from a1d4dd6 to 194d9a0 Compare March 8, 2024 18:58
fix

Verified

This commit was signed with the committer’s verified signature.
pauldambra Paul D'Ambra
Copy link

github-actions bot commented Mar 8, 2024

Size Change: 0 B

Total Size: 71.8 kB

ℹ️ View Unchanged
Filename Size
posthog-node/lib/index.cjs.js 19.5 kB
posthog-node/lib/index.esm.js 19.4 kB
posthog-web/lib/index.cjs.js 16.4 kB
posthog-web/lib/index.esm.js 16.4 kB

compressed-size-action

doh

Verified

This commit was signed with the committer’s verified signature.
pauldambra Paul D'Ambra

Verified

This commit was signed with the committer’s verified signature.
pauldambra Paul D'Ambra

Verified

This commit was signed with the committer’s verified signature.
pauldambra Paul D'Ambra

Verified

This commit was signed with the committer’s verified signature.
pauldambra Paul D'Ambra
@pauldambra pauldambra changed the title chore(ci): add bundle checker chore(ci): fix bundle checker Mar 8, 2024
@marandaneto
Copy link
Member

posthog-node do we care?

much less than the others, but it'd be nice as well, not a blocker.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pauldambra pauldambra merged commit 73fa0c1 into main Mar 9, 2024
4 checks passed
@pauldambra pauldambra deleted the chore/bundle-checker branch March 9, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants