Set initial currentSessionId, log only with debug flag on. #335
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2025 15:26
…Id for the first time after a sessionId after starting session replay with it, and a broken test fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are seeing constant logs about the replay session Id not being rotated and it appeared to be a something going wrong. In reality it seems that this was just meant to be debug info so I wrapped it in that flag. Upon closer inspection it seems that the currentSessionId will never have a value so this is now being set after the session replay starts with a session Id the first time.
Changes
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes