and distinct_id

PostHog · Mar 23, 2024 · a9433e0 · a9433e0
1 parent 33999c7
commit a9433e0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/src/__tests__/posthog-core.js b/src/__tests__/posthog-core.js
@@ -35,7 +35,7 @@ describe('posthog core', () => {
     })
 
     describe('bootstrap()', () => {
-        it('handles reasonable typos', async () => {
+        it('handles reasonable typo of distinctId', async () => {
             const ph = await createPosthogInstance(uuidv7(), {
                 advanced_disable_decide: false,
                 // NB typo of `distinctID` as `distinctId` (lower csae `d`)
@@ -44,7 +44,16 @@ describe('posthog core', () => {
             expect(ph.config.bootstrap.distinctID).toEqual('anon-id')
         })
 
-        it('handles reasonable typos without overidding', async () => {
+        it('handles reasonable typo of distinct_id', async () => {
+            const ph = await createPosthogInstance(uuidv7(), {
+                advanced_disable_decide: false,
+                // NB typo of `distinctID` as `distinctId` (lower csae `d`)
+                bootstrap: { distinct_id: 'anon-id' },
+            })
+            expect(ph.config.bootstrap.distinctID).toEqual('anon-id')
+        })
+
+        it('handles reasonable typos without overriding', async () => {
             const ph = await createPosthogInstance(uuidv7(), {
                 advanced_disable_decide: false,
                 // NB typo of `distinctID` as `distinctId` (lower csae `d`)

diff --git a/src/posthog-core.ts b/src/posthog-core.ts
@@ -387,12 +387,12 @@ export class PostHog {
         if (
             !_isUndefined(config.bootstrap) &&
             _isUndefined(config.bootstrap.distinctID) &&
-            (config.bootstrap as any).distinctId
+            ((config.bootstrap as any).distinctId || (config.bootstrap as any).distinct_id)
         ) {
             // distinctId (lowercase d) is a reasonable typo for distinctID
             // that we have seen in the wild
-            logger.warn('bootstrap distinctId is a typo. It should be distinctID (capital D). Copying the value.')
-            config.bootstrap.distinctID = (config.bootstrap as any)?.distinctId
+            logger.info('bootstrap distinctId is a typo. It should be distinctID (capital D). Copying the value.')
+            config.bootstrap.distinctID = (config.bootstrap as any).distinctId || (config.bootstrap as any).distinct_id
         }
 
         // isUndefined doesn't provide typehint here so wouldn't reduce bundle as we'd need to assign