Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reloading toolbar after closing #1095

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Conversation

benjackwhite
Copy link
Collaborator

Changes

Noticed you can't re-open the toolbar programatically after closing it.

  • Changed the logic to check for existing localstorage key. If it exists then exit, otherwise re-open the toolbar.
  • Also cleaned up some code around loading the script

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Mar 22, 2024
@benjackwhite benjackwhite requested a review from pauldambra March 22, 2024 11:03
Copy link

github-actions bot commented Mar 22, 2024

Size Change: +838 B (0%)

Total Size: 943 kB

Filename Size Change
dist/array.full.js 225 kB +208 B (0%)
dist/array.js 124 kB +210 B (0%)
dist/es.js 124 kB +210 B (0%)
dist/module.js 125 kB +210 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 106 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll trust the test 👍

@benjackwhite benjackwhite merged commit b5f783c into main Mar 25, 2024
13 checks passed
@benjackwhite benjackwhite deleted the fix/toolbar-multiple-loads branch March 25, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants