Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're clearly hitting a pathological case in the CSS processing for some folks
my guess is something is repeating the check due to run away mutations or something in a tight loop... or maybe it is just bad at very large strings 🤷
quoting my old colleague Chris Sewart about peformance
you can do it faster
do it less
or not do it
let's cache our results as we go so that we only run the nested check or the regex replace once per input
you can see the test here PostHog/posthog-rrweb#17
we see results like
that second execution will be O(1)
while first execution is O(n)
so where O(n) is large this should be a much bigger improvement