fix(flags): store setOnce properties in locally persisted feature flag props #1716
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context: https://posthoghelp.zendesk.com/agent/tickets/24489
Include
setOnce
properties in the locally persisted feature flag person properties: https://posthog.com/docs/feature-flags/adding-feature-flag-code#automatic-overridesThese are stored in local storage, but only used by feature flags for passing into the
/decide
call. This means that we should be safe fromsetOnce
properties inadvertently overwriting previous property values.Checklist