-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: canvas quality value #1727
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR fixes a bug in canvas recording quality handling by properly converting string values to numbers before applying range validation.
- Added type safety and parseFloat conversion for canvas quality values in
src/extensions/replay/sessionrecording.ts
- Added comprehensive test matrix in
sessionrecording.test.ts
to validate quality/fps parsing edge cases - Fixed default value handling (0.4 for quality, 4 for fps) when values are null/undefined
- Improved clampToRange function usage by providing explicit default values
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: +650 B (+0.02%) Total Size: 3.3 MB
ℹ️ View Unchanged
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
when clamping canvas quality to range we aren't first checking it's a number 😓
this improves that and adds a matrix test to validate the config parsing