Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase message and batch sizes #108

Merged
merged 6 commits into from
Dec 4, 2023
Merged

feat: increase message and batch sizes #108

merged 6 commits into from
Dec 4, 2023

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Dec 1, 2023

Our limits were too conservative, leading to legitimate events being dropped. Let's raise:

  • event size 32KB -> 900KiB (hard limit 1MiB)
  • batch size 500KB -> 5MiB (hard limit 20MiB)

@xvello xvello requested a review from tiina303 December 1, 2023 16:16
@xvello xvello merged commit 33ba5d6 into master Dec 4, 2023
2 checks passed
@xvello xvello deleted the xvello/sizes branch December 4, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

@tiina303 tiina303 tiina303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xvello @tiina303 @benjackwhite