Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Homepage and docs overflow #10201

Closed

Conversation

Davidmoreen
Copy link

@Davidmoreen Davidmoreen commented Dec 20, 2024

Changes

On mobile devices content on posthog.com and on posthog.com/docs would overflow the viewport causing the page to scroll horizontally.

What I did

  • Removed PHP from 'Server-side libraries' list on home page (php libraries are usually listed on subpages)
  • Added horizontal overflow to tables in Layouts.scss

Screenshots

Feature Before After
Homepage pg_homepage_before ph_homepage_after
Docs ph_docs_before ph_docs_after

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Article checklist

  • I've added (at least) 3-5 internal links to this new article
  • I've added keywords for this page to the rank tracker in Ahrefs
  • I've checked the preview build of the article
  • The date on the article is today's date
  • I've added this to the relevant "Tutorials and guides" docs page (if applicable)

Useful resources

Copy link

vercel bot commented Dec 20, 2024

@Davidmoreen is attempting to deploy a commit to the PostHog Team on Vercel.

A member of the Team first needs to authorize it.

@@ -335,6 +336,7 @@ table {
padding-top: 0;
margin-bottom: 1.45rem;
line-height: 1.45rem;
overflow-x: auto;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using auto will remove the scroll bar if the width of the table fits

@Davidmoreen Davidmoreen marked this pull request as ready for review December 20, 2024 18:18
Copy link

vercel bot commented Dec 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Dec 23, 2024 7:14pm

@corywatilo
Copy link
Collaborator

Maybe we should wrap the homepage one (or just selectively hide it) vs removing altogether?

@smallbrownbike
Copy link
Collaborator

Thanks for highlighting this and for your proposed fix; we appreciate it! We decided on a different approach (#10215, #10214), but we're happy to review any future PRs. 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants