Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local dev instructions #9118

Merged

Conversation

annapowellsmith
Copy link
Contributor

@annapowellsmith annapowellsmith commented Aug 6, 2024

Changes

  1. Copies the M1-specific setup instructions to the README, from Developing the website.

  2. Clarify local dev setup for the main posthog repo:

  • Restructure headings to separate the codespace/non-codespace options
  • Restructure headings to clarify prerequisites
  • Clarify how to set up the codespace.

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links

Copy link

vercel bot commented Aug 6, 2024

@annapowellsmith is attempting to deploy a commit to the PostHog Team on Vercel.

A member of the Team first needs to authorize it.

README.md Outdated Show resolved Hide resolved
contents/handbook/engineering/developing-locally.md Outdated Show resolved Hide resolved
Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Aug 8, 2024 2:37pm

Restructure headings and clarify codespace instructions.
Copy M1 instructions here from the 'Developing the website' page.
@annapowellsmith annapowellsmith force-pushed the update-local-dev-instructions branch from 82ab6c9 to a2cfb36 Compare August 8, 2024 09:37
@annapowellsmith
Copy link
Contributor Author

Thanks for the review @ivanagas! I've added a fix commit, but please let me know if you prefer amends to the previous commits.

Copy link
Contributor

@ivanagas ivanagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ivanagas ivanagas enabled auto-merge (squash) August 8, 2024 14:18
@ivanagas ivanagas merged commit 519f4c7 into PostHog:master Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants