fix: mobile project settings network labels #26318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Nov 20, 2024
| @@ -252,7 +252,7 @@ function UrlConfigSection({ | |||
| </div> | |||
| <p>{description}</p> | |||
|
|
|||
| <p>`${title} is only available for JavaScript Web.`</p> | |||
| <p>{title} is only available for JavaScript Web.</p> | |||
marandaneto
commented
Nov 20, 2024
| @@ -115,6 +115,13 @@ export function NetworkCaptureSettings(): JSX.Element { | |||
| This setting controls if performance and network information will be captured alongside recordings. The | |||
| network requests and timings will be shown in the recording player to help you debug any issues. | |||
| </p> | |||
| <p> | |||
There was a problem hiding this comment.
this is now after the desc. and before the toggle as any other.
marandaneto
commented
Nov 20, 2024
| </Link>{' '} | ||
| , where they can be configured directly in code. | ||
| </p> | ||
| <p>Capture headers and body are only available for JavaScript Web.</p> |
There was a problem hiding this comment.
so people don't try to find those on mobile via code
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated16 snapshot changes in total. 0 added, 16 modified, 0 deleted:
Triggered by this commit. |
fuziontech
added a commit
that referenced
this pull request
Nov 21, 2024
* master: (66 commits) feat: display line context in stack frames (#26254) fix(experiments HogQL): fix funnels filter in prepare_query (#26327) fix(hogql): Support parsing dw properties with nested values (#26321) fix(err): include raw js frame on frame content in pg (#26326) fix: mobile project settings network labels (#26318) fix: reduce perms from 3 to 2 for test perf (#26322) feat: add new alerts feature for product_analytics (#26320) feat(experiments): Enable holdouts for everyone (#26301) feat: reorg inspector list rows (#26243) feat: Split-up batch exports into sync and async (#26294) fix(data-warehouse): Fix custom series colors in chart tooltips (#26310) feat(cdp): adjust zapier destination description (#26313) fix(insights): prevent race condition (#26265) feat(product-assistant): evaluation pipeline (#26179) chore: session replay project config for mobile - what is possible (#26289) feat(cdp): make hash functions return null if the input is null (#26311) feat(err): cymbal for all teams (#26312) feat(hogql): Allow breakdowns for lazy-joined tables (#26302) feat: create events table to store last 7 days of data (#26239) chore: Bump batch exports start jitter (#26278) ...
thmsobrmlr
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
follow up #26289
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?