fix: allow full_sorting_merge in funnels #26610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,8 @@ | |||
| ) | |||
| from posthog.types import EntityNode, ExclusionEntityNode | |||
|
|
|||
| JOIN_ALGOS = "direct,parallel_hash,hash,full_sorting_merge" | |||
There was a problem hiding this comment.
for memory issues why don't we go for auto? performance concerns?
There was a problem hiding this comment.
when i tested it, it took longer and timed out on metabase.
| @@ -195,7 +196,9 @@ def get_query(self) -> ast.SelectQuery: | |||
| """, | |||
| {"fill_query": fill_query, "inner_select": inner_select}, | |||
| ) | |||
| return cast(ast.SelectQuery, s) | |||
| s = cast(ast.SelectQuery, s) | |||
| s.settings = HogQLQuerySettings(join_algorithm=JOIN_ALGOS) | |||
There was a problem hiding this comment.
might be safer to first check emptiness and then override s.settings, cause if in future parse_select starts setting query settings as well, those will be lost
anirudhpillai
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Joining against person_distinct is causing memory issues on certain queries for certain users
https://posthog.slack.com/archives/C076E99B152/p1733217417080439
Changes
Allow "full_sorting_merge" for funnels, which greatly reduces memory usage.
https://clickhouse.com/docs/en/operations/settings/settings#join_algorithm