Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): Set up initial backend for feature management #26628

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

feat(flags): Set up initial backend for feature management #26628

wants to merge 61 commits into from

Conversation

havenbarnes
Copy link
Contributor

@havenbarnes havenbarnes commented Dec 4, 2024 •
edited
Loading

Problem

Follow up to https://github.com/PostHog/posthog/pull/26363/files

Changes

Adds the following endpoints for feature management CRUD ops:

GET    /api/projects/{project_id}/features/         - List all features
POST   /api/projects/{project_id}/features/         - Create a feature
GET    /api/projects/{project_id}/features/{id}/    - Get specific feature
PUT    /api/projects/{project_id}/features/{id}/    - Full update
PATCH  /api/projects/{project_id}/features/{id}/    - Partial update

GET    /api/projects/{project_id}/features/{id}/primary_feature_flag/    - Get primary flag
GET    /api/projects/{project_id}/features/{id}/feature_flags/           - Get all flags
GET    /api/projects/{project_id}/features/{id}/experiments/             - Get experiments
GET    /api/projects/{project_id}/features/{id}/early_access_features/   - Get EAFs

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added API tests

havenbarnes and others added 30 commits November 22, 2024 13:26
@havenbarnes
feat(flags): Set up initial UI-reorganization for feature management
0846ff6
@havenbarnes
tweak
b345652
@havenbarnes
properly handle New Feature / New Flag -> Cancel navigation
0e42571
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
7bd1ee1 
…ure-management-ui-setup
@havenbarnes
handle breadcrumbs properly based on ff
32a11e2
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
3c45f0e 
…ure-management-ui-setup
@havenbarnes
Merge branch 'master' into feature-management-ui-setup
e2300bc
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
0a2294a 
…ure-management-ui-setup
@havenbarnes
cleanup
b2c36b8
@havenbarnes
tweak
745bad1
@havenbarnes
Merge branch 'feature-management-ui-setup' of https://github.com/Post…
b20b91c 
…Hog/posthog into feature-management-ui-setup
@havenbarnes
tweak
dbba27e
@havenbarnes
tweak
4419ec0
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
c07d6d4 
…ure-management-ui-setup
@havenbarnes
Re-worked with master-detail pattern
e98fc0d
@havenbarnes
tweak
3d35964
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
75181d7 
…ure-management-ui-setup
@havenbarnes
tweak
0bef6a7
@havenbarnes
stash
00a837b
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
8f1e249 
…ure-management-backend-setup
@havenbarnes
stash
19719f4
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
38a761f 
…ure-management-backend-setup
@havenbarnes
Initial endpoints, still needs tests and FE integration
9008eb5
@havenbarnes
Merge branch 'master' of https://github.com/PostHog/posthog into feat…
31fa157 
…ure-management-ui-setup
@havenbarnes
Merge branch 'feature-management-ui-setup' of https://github.com/Post…
c0d5fdf 
…Hog/posthog into feature-management-backend-setup
@havenbarnes
Add tests for feature viewset
199b552
@havenbarnes
tweak
00b3f8b
@github-actions
Update query snapshots
a51dd17
@havenbarnes
tweak
38a52c9
@github-actions
Update query snapshots
8902068
Base automatically changed from feature-management-ui-setup to master December 6, 2024 19:39
havenbarnes
havenbarnes commented Dec 9, 2024
View reviewed changes
posthog/models/early_access_feature.py
@@ -30,6 +30,7 @@ class Stage(models.TextChoices):
stage = models.CharField(max_length=40, choices=Stage.choices)
documentation_url = models.URLField(max_length=800, blank=True)
created_at = models.DateTimeField(auto_now_add=True)
feature_management = models.ForeignKey("posthog.Feature", on_delete=models.SET_NULL, null=True)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Why feature_management vs just feature?"

The existing feature_flag foreign key on some of these models uses related names that would clash with feature:

related_name="features",
related_query_name="feature",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, that's a bit annoying, but I understand the choice.

@havenbarnes havenbarnes marked this pull request as ready for review December 9, 2024 19:59
@havenbarnes havenbarnes requested a review from dmarticus December 9, 2024 19:59
dmarticus
dmarticus approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Seems like CI is a bit mad but I think the changes are sensible and the tests are good.

posthog/models/early_access_feature.py
@@ -30,6 +30,7 @@ class Stage(models.TextChoices):
stage = models.CharField(max_length=40, choices=Stage.choices)
documentation_url = models.URLField(max_length=800, blank=True)
created_at = models.DateTimeField(auto_now_add=True)
feature_management = models.ForeignKey("posthog.Feature", on_delete=models.SET_NULL, null=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, that's a bit annoying, but I understand the choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarticus dmarticus dmarticus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havenbarnes @dmarticus