-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update breadcrumb title for saved and loaded pipeline destination #28174
fix: Update breadcrumb title for saved and loaded pipeline destination #28174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds breadcrumb title updates for pipeline destinations in PostHog's frontend, fixing an issue where destinations showed as "Unnamed" in navigation.
- Added
setBreadcrumbTitle
action call inloadHogFunctionSuccess
listener to update title when loading existing destinations - Added
setBreadcrumbTitle
action call inupsertHogFunctionSuccess
listener to update title after saving destinations - Connected
hogFunctionConfigurationLogic
topipelineNodeLogic
to enable breadcrumb title updates - Ensures breadcrumb title reflects the actual destination name rather than defaulting to "Unnamed"
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Hey @benjackwhite, I think I have a fix for #25807 if you'd like to take a look when you have a chance. |
Nice! Not sure why we didn't have that fix ages ago! |
@benjackwhite Thanks for the review! Do I need to do anything to get the PR merged? |
Merged it! |
Problem
When a pipeline destination is saved or loaded you see "Unnamed" in the breadcrumbs. This will update the breadcrumb to be the name of the saved or loaded pipeline destination.
Closes #25807
Changes
After changes you can see the name displaying in the breadcrumbs.
![image](https://private-user-images.githubusercontent.com/10119024/408777100-741485de-27b4-4e22-9a99-97db14dd3999.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODUyOTIsIm5iZiI6MTczOTE4NDk5MiwicGF0aCI6Ii8xMDExOTAyNC80MDg3NzcxMDAtNzQxNDg1ZGUtMjdiNC00ZTIyLTlhOTktOTdkYjE0ZGQzOTk5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEwNTYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVmNGE1NTQxYWY5MTlhYTRmMjJiMmVhMjE5YjI4MjBmMjg1MGY0MmQzMjgwNDA4YTI2ODM1Yzg4OWU1Yzc1YjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ACbVDm1mtKCT1vAG8ufdO7kS9Dys8jb1wp1b2iDpTWU)
Does this work well for both Cloud and self-hosted?
Should work for both just fine.
How did you test this code?
I tested this code by creating a new Discord pipeline destination, saving it, verifying the name showed up in the breadcrumbs. I also tried refreshing the page and loading an existing destination and verifying the name was showing up correctly.