Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update breadcrumb title for saved and loaded pipeline destination #28174

Merged

Conversation

JacobLynch
Copy link
Contributor

Problem

When a pipeline destination is saved or loaded you see "Unnamed" in the breadcrumbs. This will update the breadcrumb to be the name of the saved or loaded pipeline destination.

Closes #25807

Changes

After changes you can see the name displaying in the breadcrumbs.
image

Does this work well for both Cloud and self-hosted?

Should work for both just fine.

How did you test this code?

I tested this code by creating a new Discord pipeline destination, saving it, verifying the name showed up in the breadcrumbs. I also tried refreshing the page and loading an existing destination and verifying the name was showing up correctly.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds breadcrumb title updates for pipeline destinations in PostHog's frontend, fixing an issue where destinations showed as "Unnamed" in navigation.

  • Added setBreadcrumbTitle action call in loadHogFunctionSuccess listener to update title when loading existing destinations
  • Added setBreadcrumbTitle action call in upsertHogFunctionSuccess listener to update title after saving destinations
  • Connected hogFunctionConfigurationLogic to pipelineNodeLogic to enable breadcrumb title updates
  • Ensures breadcrumb title reflects the actual destination name rather than defaulting to "Unnamed"

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@JacobLynch
Copy link
Contributor Author

Hey @benjackwhite, I think I have a fix for #25807 if you'd like to take a look when you have a chance.

@benjackwhite benjackwhite self-requested a review February 4, 2025 15:42
@benjackwhite benjackwhite requested review from MarconLP and removed request for MarconLP February 5, 2025 10:03
@benjackwhite
Copy link
Contributor

Nice! Not sure why we didn't have that fix ages ago!

@benjackwhite benjackwhite changed the title Fix: update breadcrumb title for saved and loaded pipeline destinations fix: Update breadcrumb title for saved and loaded pipeline destination Feb 5, 2025
@benjackwhite benjackwhite self-assigned this Feb 5, 2025
@JacobLynch
Copy link
Contributor Author

@benjackwhite Thanks for the review! Do I need to do anything to get the PR merged?

@benjackwhite benjackwhite merged commit de1b631 into PostHog:master Feb 6, 2025
@benjackwhite
Copy link
Contributor

Merged it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Data pipeline Destination name shows as "Unnamed" despite being named
2 participants