-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdp): add pii hashing transformation #28446
Open
meikelmosby
wants to merge
6
commits into
master
Choose a base branch
from
feat/cdp/add-pii-hashing-transformation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+548
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Introduced a new PII data hashing transformation that uses SHA-256 to protect sensitive user data in event properties, with configurable property selection.
- Implemented SHA-256 hashing in
/plugin-server/src/cdp/templates/_transformations/pii-hashing/pii-hashing.template.ts
with default IP address hashing - Added comprehensive test suite in
pii-hashing.template.test.ts
covering edge cases like empty values and invalid paths - Template preserves original event structure by creating a copy before modification
- Includes input schema for flexible property selection via dictionary configuration
- Maintains data integrity by only hashing non-empty values and leaving unspecified properties unchanged
3 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
plugin-server/src/cdp/templates/_transformations/pii-hashing/pii-hashing.template.ts
Outdated
Show resolved
Hide resolved
plugin-server/src/cdp/templates/_transformations/pii-hashing/pii-hashing.template.ts
Outdated
Show resolved
Hide resolved
plugin-server/src/cdp/templates/_transformations/pii-hashing/pii-hashing.template.ts
Show resolved
Hide resolved
plugin-server/src/cdp/templates/_transformations/pii-hashing/pii-hashing.template.test.ts
Show resolved
Hide resolved
plugin-server/src/cdp/templates/_transformations/pii-hashing/pii-hashing.template.test.ts
Outdated
Show resolved
Hide resolved
benjackwhite
requested changes
Feb 12, 2025
plugin-server/src/cdp/templates/_transformations/pii-hashing/pii-hashing.template.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
we want a way to hash PII through transformations, also on nested values e.g.
properties.$ip
orproperties.$set.$email
Changes
properties.
properties.$set.$default_browser
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?