feat: Destination tests for batch exports #28687
Conversation
tomasfarias
force-pushed
the
feat/destination-tests-for-batch-exports
branch
from
43f589a to
2dab705
Compare
posthog/batch_exports/http.py
Outdated
| @action(methods=["POST"], detail=True) | ||
| def test(self, request: request.Request, *args, **kwargs) -> response.Response: |
There was a problem hiding this comment.
is this endpoint just for fetching a test (and it's list of steps) for a given batch export?
There was a problem hiding this comment.
Yeah, thought about having everything in a single endpoint, but it looked too complicated. I'd be happy to rename this to something more verbose though...
There was a problem hiding this comment.
I think it does make sense to get a list of possible tests upfront, especially if we want to add them to destinations one at a time, since the frontend could probably not even show a test button if there are no tests to run for example. Was also wondering if it could just be a GET method if it's not actually running anything
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.
10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This adds a test configuration component in the batch exports configuration page. Currently, tests are optional.
Eventually, we could allow partial retries
tomasfarias
force-pushed
the
feat/destination-tests-for-batch-exports
branch
from
b26a321 to
752805b
Compare
|
Size Change: +220 B (0%) Total Size: 9.7 MB ℹ️ View Unchanged
|
Problem
The most common type error when interacting with batch exports are user configuration errors. This PR introduces a new framework for "Destination tests": Tests that can be called from our API to evaluate a given batch export configuration.
Changes
Frontend screenshots:
All passed:
Error:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
New unit tests.