feat(assistant): stop a generation #28810
Conversation
|
Size Change: +4.97 kB (+0.05%) Total Size: 9.71 MB
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.
18 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
PR Summary
(updates since last review)
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.
21 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| return cls( | ||
| intermediate_steps=[], | ||
| plan="", | ||
| graph_status="", | ||
| memory_updated=False, | ||
| memory_collection_messages=[], | ||
| root_tool_call_id="", | ||
| root_tool_insight_plan="", | ||
| root_tool_insight_type="", | ||
| root_tool_calls_count=0, | ||
| ) |
There was a problem hiding this comment.
Shouldn't this be just cls()? I'm just unsure why e.g. the default intermediate_steps value on the model itself isn't list(), rather than None
There was a problem hiding this comment.
It's a workaround for now. LangGraph doesn't correctly merge states, so all None values are ignored despite being explicitly set. More context. intermediate_steps can't be an empty list by default because it will just replace state unexpectedly. I'm planning to migrate pydantic states to a plain TypedDict.
There was a problem hiding this comment.
Ah, that issue. Alright, let's keep these "manual defaults" then
Problem
Customers want to stop the generation if things go south.
Changes
statusto the Conversation model that controls if the double-texting is allowed (parallel executions of the same conversation).runmethod.Demo
Recovering after a failed generation
(it wasn't possible before)
Does this work well for both Cloud and self-hosted?
No
How did you test this code?
Manual tests, unit tests.