feat: allow widget surveys to be repeated indefinitely #28896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasheriques
force-pushed
the
feat/allow-widget-surveys-to-be-repeated-indefinitely
branch
from
b21b5ae to
411da62
Compare
|
Size Change: 0 B Total Size: 9.71 MB ℹ️ View Unchanged
|
marandaneto
reviewed
Feb 19, 2025
marandaneto
reviewed
Feb 19, 2025
marandaneto
reviewed
Feb 19, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.
14 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
marandaneto
reviewed
Feb 19, 2025
marandaneto
reviewed
Feb 19, 2025
marandaneto
reviewed
Feb 19, 2025
marandaneto
approved these changes
Feb 19, 2025
|
Depends on PostHog/posthog-js#1752 |
marandaneto
reviewed
Feb 19, 2025
| label: 'Repeat on a schedule', | ||
| 'data-attr': 'survey-iteration-frequency-days', | ||
| disabledReason: surveysRecurringScheduleDisabledReason, | ||
| }, | ||
| { |
There was a problem hiding this comment.
is there a tooltip or label that we can mention it requires the JS SDK version >= x?
There was a problem hiding this comment.
i'll add it once we merge the JS SDK PR and have ther version available
lucasheriques
deleted the
feat/allow-widget-surveys-to-be-repeated-indefinitely
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
feature request: #18157
it'll be closed the the posthog-js PR to actually use those values
Changes
adds a new option for repeating survey - "All the time"
which means the survey will be displayed every time the conditions match
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
unit tests for the endpoint; smoke tests to see if survey is being created properly