chore(flags): add exception logging during DatabaseError handling in flag matching logic #29839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flag matching logic
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds detailed exception logging for DatabaseError handling in the feature flag matching logic, improving observability for database-related issues during flag evaluation.
- Added exception logging in
group_types_to_indexesmethod to capture database errors during group type mapping retrieval - Added exception logging in
query_conditionsmethod to track database errors during flag condition evaluation - Both logs include error message and stack trace for better debugging context
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
danielxnj
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Context: https://posthog.slack.com/archives/C08G5CFHC3V/p1741798684938329?thread_ts=1741620851.975329&cid=C08G5CFHC3V
Changes
Just two exception logs
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Existing coverage sufficient for validating syntax