Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add an opt-in count to early access management #29841

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joethreepwood
Copy link
Contributor

Problem

I want to know who is opted in to each feature, but I don't want to click in to each feature one by one.

Wouldn't it be nice if a LOWLY PRODUCT MARKETER could add a column to the early access management table to show the number of opted-in users for each feature?

(A: Yes, but it'd be nicer if his Macbook was capable of running a local version so he can test it)

Changes

Tries to add a nice column of opted in users to the early access management table.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@joethreepwood joethreepwood self-assigned this Mar 12, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added opt-in count functionality to early access features management table, allowing users to see the number of users opted into each feature without navigating to individual feature pages.

  • Added optional opt_in_count field to EarlyAccessFeatureType interface in /frontend/src/types.ts
  • Implemented new "Opted-in users" column with sorting in /products/early_access_features/frontend/EarlyAccessFeatures.tsx
  • Added API calls in /products/early_access_features/frontend/earlyAccessFeaturesLogic.ts to fetch opt-in counts, though N+1 queries could impact performance
  • Consider optimizing the API calls by implementing a bulk fetch endpoint to reduce the number of requests

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant