Reduces pool resource locking #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pond continuation. This ensures that the pool resource is freed as soon as the database operation is complete
|
Makes sense, thanks for the fix. I bet we could create a regression test case. Could fork a bunch of threads in test that all call a stored procedure which raises an exception. The test would check that it never gets that "current transaction is aborted" error. |
| Right c -> do | ||
| resOrError <- handleReq c | ||
| either (respond . pgErrResponse) respond resOrError | ||
| either (return . pgErrResponse) return resOrError |
There was a problem hiding this comment.
See if this simplification compiles
return $ either pgErrResponse id resOrError
|
Tonight I'm looking at how to apply the suggestion from hspec/hspec-wai#32 to make parallel requests in a test case. |
|
Cool, because I would get stuck trying to do that 😜 |
|
Closing this PR and moving over to the other one with a test added. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was based on a conversation I had with @ruslantalpa in the gitter and on some ad-hoc tests using
threadDelay.I'm still not sure if I should include some kind of test or benchmark to validate this change.
The change is very simple though, I return the results from withResource function before applying the respond continuation. This ensures that the pool resource is freed as soon as the database operation is complete