-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improving the donation modal & projects loading #122
Conversation
M-Rb3
commented
May 22, 2024
•
edited
Loading
edited
- move the success donation modal for the web wallet to the root.
- make all the fetching done on the pot page to use bos storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the broken test before merging, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to work on home page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially says "0 projects", then says "Loading...", then first load/render of project cards displays essentially blank cards before finally the populated cards are displayed. Would be better to display skeleton cards until the data has loaded, and remove the "Loading..." text.
See video:
Screen.Recording.2024-05-23.at.12.05.40.PM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still taking a super long time for the projects to load (see screen recording). Is that because we wait to calculate the estimated matched amount for each project card?
Two options:
-
Refactor so that the estimated matched amounts calculate within the context of the card and not the ListPage component, but this might be tricky / not worth the time
-
Quick and dirty: remove Estimated Matched Amount from project card, since we have it in "Payouts" now anyway, plus the leaderboard. Just comment out, don't completely delete it, in case we change our minds.
I vote for #2
Screen.Recording.2024-05-23.at.7.36.36.PM.mov
Oh also - please remove the 'Loading...' text in the UI while projects are loading. it should go straight to skeletons. |
…p-alem into feat/update-card
Feat/update card
@lachlanglen pot.test.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Hot fix card width and sort filter