Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/modal-v2 #514

Merged
merged 17 commits into from
Apr 6, 2024
Merged

Enhance/modal-v2 #514

merged 17 commits into from
Apr 6, 2024

Conversation

M-Rb3
Copy link
Member

@M-Rb3 M-Rb3 commented Apr 3, 2024

No description provided.

@M-Rb3 M-Rb3 requested a review from lachlanglen April 4, 2024 22:19
@M-Rb3 M-Rb3 marked this pull request as ready for review April 4, 2024 22:19
Copy link
Collaborator

@lachlanglen lachlanglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donating from project card / outside of pot:

  1. Even if only one pot available, should still show up/down arrows on select input, with single option:
Screenshot 2024-04-05 at 9 23 25 AM
  1. Add option to remove chef fee for Quadratically Matched Donation:
Screenshot 2024-04-05 at 12 58 28 PM
  1. When I select "Quadratically matched donation" and proceed to "Confirm donation", Contract ID is donate.potlock.near which means it is a direct donation

  2. When donating to a single project, should be some indication on the "Confirm donation" page of which project I'm donating to. (No designs for this yet, I have asked Emmanuel to provide)

  3. When donating to multiple projects, carat on "Confirm donation" screen is back to front (should point to side when collapsed, and down when expanded). Also, should be expanded by default.

Screenshot 2024-04-05 at 1 03 08 PM Screenshot 2024-04-05 at 1 04 09 PM
  1. USD amount should always have two decimal places:
Screenshot 2024-04-05 at 1 04 46 PM Screenshot 2024-04-05 at 1 05 58 PM Screenshot 2024-04-05 at 1 09 47 PM
  1. When donate modal is displayed, background content (e.g. pot page) should not be scrollable

  2. Since we can't rely on these token APIs right now, should only display available token balance IF the token balances (both NEAR & FT) were fetched successfully.

If they have not been fetched successfully:

  • Available balance should not display
  • Input amount should not be validated against available balance
  • FT token selection should not be available (if FT balances have not been successfully fetched)
  1. pass a potId URL param through to the project page if a project card is clicked within the pot, so that if a user navigates to a project from a pot and then clicks "Donate" it passes the potId through to the donate modal and defaults to quadratically matched donation

  2. Remove border radius for full screen modal on mobile:

Screenshot 2024-04-05 at 1 11 50 PM
  1. Scrollable area is really small on mobile and difficult to use. Not sure of the best solution to this. Perhaps make the entire section (under the header) scrollable, so more projects are viewable at once?
Screenshot 2024-04-05 at 1 12 46 PM
  1. "breakdown" should have uppercase "B"
Screenshot 2024-04-05 at 1 13 40 PM
  1. checkboxes too small on mobile:
Screenshot 2024-04-05 at 1 14 42 PM

Copy link
Collaborator

@lachlanglen lachlanglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you!

@lachlanglen lachlanglen merged commit ca3eafc into main Apr 6, 2024
1 of 2 checks passed
@lachlanglen lachlanglen deleted the enhance/modal-v2 branch April 6, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants