Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Component and Components Library PotLock #548

Merged
merged 9 commits into from
May 19, 2024

Conversation

saadiqbal-dev
Copy link
Contributor

@saadiqbal-dev saadiqbal-dev commented Apr 25, 2024

  • 4 Variants Button (Tip on Potlock)
  • Components Library Draft
2024-04-25.20-29-05.mp4

@elliotBraem
Copy link
Collaborator

There looks to be some disparity between the buttons in this library and whats in potlock UI

  1. There should be a darker bottom border:

Screenshot 2024-04-25 at 11 41 16 AM

  1. Also, the hover animation -- I personally think it could match the button on nadabot: https://www.nada.bot/
  2. Option to have icon on the right

Screenshot 2024-04-25 at 11 43 38 AM

  1. Remove the 2 extra divs in the first example -- can you do a different example that "Tip on Potlock"? Since there is a dedicated button for this (TipOnPotlock example looks good)

@elliotBraem
Copy link
Collaborator

Screenshot 2024-04-29 at 10 40 09 AM

Is this correct @saadiqbal-dev? No padding?

@@ -0,0 +1,6 @@
const { Volunteer } = VM.require("potlock.near/widget/Components.Icons.Volunteer");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update all potlock.near to "old.potlock.near" please

@elliotBraem elliotBraem merged commit f2927f3 into PotLock:main May 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants