Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #112

Merged
merged 83 commits into from
Jun 3, 2024
Merged

V2 #112

merged 83 commits into from
Jun 3, 2024

Conversation

carina-akaia
Copy link
Collaborator

@carina-akaia carina-akaia commented May 2, 2024

No description provided.

@carina-akaia carina-akaia self-assigned this May 2, 2024
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nadabot-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 0:24am

@carina-akaia carina-akaia linked an issue May 2, 2024 that may be closed by this pull request
@carina-akaia
Copy link
Collaborator Author

carina-akaia commented May 28, 2024

@lachlanglen Should this link say "Groups" instead of "Rules" as well?
image

@carina-akaia
Copy link
Collaborator Author

5. Rule description isn't very well-located. Let's prepend the rule type so it's clearer, e.g. "Subtractor: Total amount of points is reduced by 10% for every check inside the group."

@lachlanglen does that mean we're getting rid of the separate rule type tags on group list items?

@carina-akaia carina-akaia changed the base branch from main to staging May 29, 2024 15:15
@carina-akaia carina-akaia changed the base branch from staging to main May 29, 2024 15:16
@lachlanglen
Copy link
Contributor

@lachlanglen Should this link say "Groups" instead of "Rules" as well? image

Let's do "See All Groups & Rules"

@lachlanglen
Copy link
Contributor

  1. Rule description isn't very well-located. Let's prepend the rule type so it's clearer, e.g. "Subtractor: Total amount of points is reduced by 10% for every check inside the group."

@lachlanglen does that mean we're getting rid of the separate rule type tags on group list items?

Oh sorry, I didn't attach the screenshot for that one. Basically, keep everything how it is in the Edit Group header, but just prefix the description (which is actually the rule description) with the rule type "name" (e.g. Highest, Lowest, Subtractor etc) , since this text is not colocated with the rule type selection. Does that make sense?

Screenshot 2024-05-24 at 3 32 40 PM

Copy link
Contributor

@lachlanglen lachlanglen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@carina-akaia carina-akaia changed the base branch from main to staging June 3, 2024 12:09
@carina-akaia carina-akaia merged commit e895b76 into staging Jun 3, 2024
2 checks passed
@carina-akaia carina-akaia deleted the enhance/v2-update branch June 3, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCE] Implement V2 UI (expiry, custom args, rules/groups)
2 participants