Downloader: call Close on updates that are overwritten in (*Downlader).LoadOnce
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader).LoadOnce` When an update is replaced in `(*Downloader).LoadOnce`, the concurrency token issued by `d.r.decompressedSnapshotLimit` is lost and can no longer be accessed, and thus be released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an update that has not been loaded yet is replaced by a more recent one in
(*Downloader).LoadOnce, the concurrency token issued byd.r.decompressedSnapshotLimitis lost and can no longer be released.This eventually leads to
decompressedSnapshotLimitbeing depleted and deadlocked, in turn locking(*Downloader).LoadOnce. In effect, a Syncer may no longer download anything while still appearing healthy.