Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set nsec3param: first increase the serial and then rectify #14325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klaus-nicat
Copy link
Contributor

Short description

fixes #14323

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

…ername from the SOA RR) if configured. And then rectify.
@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9498012098

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 5415 unchanged lines in 81 files lost coverage.
  • Overall coverage decreased (-3.4%) to 61.22%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/ws-auth.cc 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 69.16%
pdns/recursordist/ext/protozero/include/protozero/config.hpp 1 0.0%
pdns/sstuff.hh 1 59.53%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/sortlist.hh 1 75.0%
pdns/dnstap.cc 2 68.82%
ext/probds/murmur3.cc 2 88.24%
pdns/backends/gsql/gsqlbackend.hh 2 96.57%
pdns/dnsname.hh 2 91.36%
pdns/opensslsigners.cc 2 61.13%
Totals Coverage Status
Change from base Build 9495982726: -3.4%
Covered Lines: 118803
Relevant Lines: 161528

💛 - Coveralls

@Habbie Habbie added this to the auth-5 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ordername for SOA not populated after setting NSEC3PARAM via API
4 participants