Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v1.10.x #823

Merged
merged 33 commits into from
Nov 11, 2024
Merged

Release/v1.10.x #823

merged 33 commits into from
Nov 11, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Nov 7, 2024

mgovers and others added 23 commits October 15, 2024 10:09
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
…into feature/private-core-module

Signed-off-by: Martijn Govers <[email protected]>
…into feature/private-core-module

Signed-off-by: Martijn Govers <[email protected]>
…into feature/private-core-module

Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
…o feature/private-core-module

Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers added the feature New feature or request label Nov 7, 2024
@mgovers mgovers self-assigned this Nov 7, 2024
@mgovers mgovers added the do-not-merge This should not be merged label Nov 7, 2024
@mgovers mgovers mentioned this pull request Nov 7, 2024
27 tasks
@mgovers mgovers changed the title bump version to v1.10.x Release/v1.10.x Nov 7, 2024
@figueroa1395
Copy link
Contributor

Solves (but not closes) #803

Why doesn't it close it?

Also, let's add to the todo list:

@mgovers
Copy link
Member Author

mgovers commented Nov 8, 2024

Solves (but not closes) #803

Why doesn't it close it?

because this is the RC (release candidate), not the release itself. the release itself is described as a separate issue in #803

Also, let's add to the todo list:

* [ ]  Update full change log in [[Release] v1.10.0 #803](https://github.com/PowerGridModel/power-grid-model/issues/803) after the above are merged.

that's part of the release itself, not the RC. the release ticket #803 has it as a TODO, and that's why this doesn't close it.

basically, there's a race condition here: you cannot generate the changelog until the RC is merged. if that would be part of this TODO, then we can't merge this PR because there's no way it can be finished before this is merged.

@mgovers
Copy link
Member Author

mgovers commented Nov 8, 2024

Windows benchmark using MSVC Release with the power_grid_model_benchmark_cpp build target looks reasonably comparable

benchmark-msvc-v1-9-0.txt
benchmark-msvc-v1-9-86.txt
benchmark-msvc-v1-10-rc.txt

@figueroa1395
Copy link
Contributor

Benchmark on Ubuntu 22.04 on WSL2 using g++-12 Release. The results look comparable as well.
benchmark-g++12-v1-9-0.txt
benchmark-g++-12-v1-9-86.txt
benchmark-g++-12-v1-10-rc.txt

@mgovers
Copy link
Member Author

mgovers commented Nov 8, 2024

Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787
Copy link
Member

TonyXiang8787 commented Nov 10, 2024

@mgovers sonar-cloud was skipped due to a old and not-needed logic. I have fixed this in 5e16d13.

Now I put the PR in ready-for-review, feel free to drag it into the merge queue on Monday.

@TonyXiang8787 TonyXiang8787 marked this pull request as ready for review November 10, 2024 10:12
Copy link

sonarcloud bot commented Nov 10, 2024

@mgovers mgovers enabled auto-merge November 11, 2024 07:00
@mgovers mgovers added this pull request to the merge queue Nov 11, 2024
@mgovers mgovers removed the do-not-merge This should not be merged label Nov 11, 2024
Merged via the queue into main with commit 1c8139c Nov 11, 2024
26 checks passed
@mgovers mgovers deleted the release/v1.10.0-rc branch November 11, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants