Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/aave use case #23

Merged
merged 19 commits into from
Apr 26, 2024
Merged

Feat/aave use case #23

merged 19 commits into from
Apr 26, 2024

Conversation

Seth-Schmidt
Copy link
Collaborator

@Seth-Schmidt Seth-Schmidt commented Mar 29, 2024 •
edited
Loading

#22

Fixes #

Checklist

  • My branch is up-to-date with upstream/main branch.
  • Everything works and tested for major version of Python/NodeJS/Go and above.
  • I ran pre-commit checks against my changes.
  • I've written tests against my changes and all the current present tests are passing.

Current behaviour

Docs currently don't have any information on Aave V3 use case

New expected behaviour

Docs will have Aave V3 overview and data points in the Existing Implementations section

Change logs

Added

  • Aave V3 implementation overview index
  • Aave V3 data point breakdown
  • Additional references to Aave use case in data sources and architecture sections
  • Deployment and extension instructions

Fixed

  • grammatical errors in Uniswap V2 data points section
  • minor changes to Uniswap V2 Closer Look at Snapshots section

Deployment Instructions

@havealakshya
Updated content on index.md
61faa1e 
Simplified, re-written sentences, fixed grammar
@havealakshya
Updated content changes on setup-and-extension.md
a97b258 
- fixed sentences
- improved written content
- simplified sentences
@havealakshya
Updated & fixed docs for data-points.md
dd22704 
- fixed sentences
- improved writing
@havealakshya
fixed sentence errors setup-and-extension.md
02bfbd0
@SwaroopH
Copy link
Member

Deployed on: https://powerloom-docs-245iq.ondigitalocean.app/docs/build-with-powerloom/use-cases/existing-implementations/aavev3-dashboard/

@kanikamishra kanikamishra self-requested a review April 19, 2024 09:57
anomit
anomit approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@anomit anomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anomit
anomit approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@anomit anomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kanikamishra
kanikamishra approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@kanikamishra kanikamishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

havealakshya
havealakshya approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@havealakshya havealakshya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanikamishra kanikamishra self-requested a review April 24, 2024 16:30
@Seth-Schmidt Seth-Schmidt merged commit 4a32419 into main Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomit anomit anomit approved these changes

@havealakshya havealakshya havealakshya approved these changes

@SwaroopH SwaroopH Awaiting requested review from SwaroopH

@xadahiya xadahiya Awaiting requested review from xadahiya

@kanikamishra kanikamishra Awaiting requested review from kanikamishra

Assignees

@Seth-Schmidt Seth-Schmidt

@havealakshya havealakshya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Seth-Schmidt @SwaroopH @anomit @kanikamishra @havealakshya