Protocol V2 docs #45
Merged
Protocol V2 docs #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Overall content is clear as far as highlighting the differences between v1 and v2 of the protocol. Starting with why the changes need to be made and breaking down each additional component into it's own section made it easy to follow as someone who hasn't use v2 yet.
I did find some minor changes to be made while going through it, made a secondary PR here:
Sulejman
reviewed
Jun 26, 2024
4 tasks
xadahiya
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation on the new components and approaches in the second version of the protocol
Checklist
Current behaviour
NA
New expected behaviour
NA
Change logs
Added
Protocol V2 docs:
Fixes PowerLoom/product#141
Deployment Instructions
NA