Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat state override block height #61

Closed
wants to merge 3 commits into from

Conversation

getjiggy
Copy link
Contributor

fixes #58

Fixes #

Checklist

  • [x ] My branch is up-to-date with upstream/develop branch.
  • [ x] Everything works and tested for Python 3.8.0 and above.
  • I ran pre-commit checks against my changes.
  • [ x] I've written tests against my changes and all the current present tests are passing.

Current behaviour

The current rpc helper doesnt support state override calls or rpc calls relating to specific block height. this PR addresses both.

New expected behaviour

This code allows state override calls at specific block heights to be made.

Change logs

Added support for state overrride calls

added support for rpc calls to specific block height.

Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing these submodule files and configs? Is this intentional? If not, better to create a fork of main, push this change, and then create a PR from there.

Left some other comments as well.

snapshotter/utils/rpc.py Show resolved Hide resolved
snapshotter/utils/rpc.py Outdated Show resolved Hide resolved
snapshotter/utils/rpc.py Outdated Show resolved Hide resolved
snapshotter/utils/rpc.py Outdated Show resolved Hide resolved
snapshotter/utils/rpc.py Show resolved Hide resolved
snapshotter/utils/rpc.py Show resolved Hide resolved
@getjiggy getjiggy closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rpc helper to support state override and block identifier
2 participants