Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix redis param name in GenericProcessorSnapshot #86

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

xadahiya
Copy link
Member

@xadahiya xadahiya commented May 8, 2024

Fixes #85

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.8.0 and above.
  • I ran pre-commit checks against my changes.

Changes

Update GenericProcessorSnapshot definition to

    @abstractmethod
    async def compute(
        self,
        epoch: PowerloomSnapshotProcessMessage,
        redis_conn: aioredis.Redis,
        rpc_helper: RpcHelper,
    ):
        pass

@xadahiya xadahiya changed the title chore: fix redis param name as defined in #85 chore: fix redis param name in GenericProcessorSnapshot May 8, 2024
Copy link
Member

@anomit anomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xadahiya xadahiya merged commit 8e0cc0c into main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenericProcessorSnapshot compute definition has incorrect redis param name
2 participants