Fix: Telegram and issue reporting improvements

[Seth-Schmidt]

Fixes ##58

Checklist

• My branch is up-to-date with upstream/develop branch.
• Everything works and tested for Python 3.8.0 and above.
• I ran pre-commit checks against my changes.
• I've written tests against my changes and all the current present tests are passing.

Current behaviour

The implementation of the telegram issue reporting service is currently inconsistent with established internal patterns, and the handling of httpx clients used is incorrect/can be improved.

New expected behaviour

I have separated the telegram reporting logic from the reporting service's in utils/callback_helpers.py. Two new functions called send_telegram_notification_sync and send_telegram_notification_async have been created. These will handle sending the notification message to the correct telegram service endpoint depending on the issue that was raised.

An additional httpx client has been added to the core snapshotter services that opens a connection pool against the telegram reporting service endpoint. The telegram and reporting service notifications will now each have their own callback helpers and clients.

The call to sleep in system_event_detector after _init_check_and_report() has completed has also been removed.

Change logs

Changed

• utils/callback_helpers.py
  • created separate helpers for telegram notifications
  • reverted changes to internal reporting helpers
• system_event_detector.py
  • updated issue reporting for new callback helpers
  • _send_telegram_epoch_processing_notification() created to remove duplicate code
  • added self._telegram_httpx_client
  • removed sleep after simulation submissions are complete
• processor_distributor.py
  • updated issue reporting for new callback helpers
  • _send_failure_notifications() created to handle internal/telegram reporting and remove duplicate code
  • added self._telegram_httpx_client
• utils/generic_worker.py
  • updated issue reporting for new callback helpers
  • _send_failure_notifications() created to handle internal/telegram reporting and remove duplicate code
  • added self._telegram_httpx_client
• utils/snapshot_worker.py
  • updated issue reporting for new callback helpers
  • uses inherited notification method
• utils/models/
  • updated telegram message models and moved them to the message_models file
  • removed deprecated models due to reporting changes

Removed

• SnapshotterReportData from utils/models/data_models.py

Deployment Instructions

No changes to deployment.