-
Notifications
You must be signed in to change notification settings - Fork 42
Implement schema option for PsDscAdapter #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some tests
@SteveL-MSFT I added one test now with a hardcoded resource manifest. I'm struggling to find out the logic how Do you mind helping me out and point me in the right direction? I would have expected the engine to call the |
@Gijsreyn to confirm this enhancement works for both Windows PowerShell and PowerShell adapters correct? |
It's been a while, but yes, I have explicitly added it to the |
@Gijsreyn can you resolve the merge conflict? |
@SteveL-MSFT The merge conflicts are resolved. I have hardcoded a resource manifest now to let the test pass, but I still need help with the earlier question. Can you guide me in the right direction, or can we pull it in for now? |
For adapters, For now, I think we should hold this PR until we resolve how it should work for any type of adapter. |
PR Summary
This pull request adresses partially the option to call
dsc resource schema -r <resourceName>
for PowerShell adapters. If I'm not wrong, there is also an overarching issue but I couldn't find it. Pardon me on it.There are other questions popping up with this pull request:
PR Context