-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix output of Assertion resource for test to resemble config and add support for array comparison #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
force-pushed
the
assert-array
branch
3 times, most recently
from
November 8, 2024 19:53
f87a4eb
to
8f499d7
Compare
SteveL-MSFT
commented
Nov 13, 2024
SteveL-MSFT
commented
Nov 13, 2024
SteveL-MSFT
commented
Nov 13, 2024
SteveL-MSFT
commented
Nov 13, 2024
tgauth
reviewed
Nov 14, 2024
anmenaga
approved these changes
Nov 14, 2024
…support for array comparison
… tests, fixed nested array search
SteveL-MSFT
force-pushed
the
assert-array
branch
from
November 17, 2024 01:29
7d61262
to
4036a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Two problems addressed by this PR:
Assertion
simply returned the actual result to look like aget
result, however, this causes the synthetic test doing a diff to fail as they don't resemble each other. To address this, added a new hidden switch--as--config
to informdsc
that this is a special case and the output needs to be transformed to a Configuration so that the synthetic test can work.Here's example of the new output:
resources
is always an array. Arrays need to be the same per the current diff rules:PR Context
Fix #165