Skip test that's too slow in ADO #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove test that's no longer run since <7.4 has been dropped.
There was a problem hiding this comment.
PR Overview
This PR skips a test that runs too slowly in ADO and removes an obsolete test that is no longer run after dropping support for PowerShell versions earlier than 7.4.
- Removed the obsolete "CanRequestCompletionsAndHandleExceptions" test.
- Changed the attribute on "CanSendGetCommandRequestAsync" from [Fact] to [SkippableFact] and added a Skip.If condition for TF_BUILD environments.
Reviewed Changes
| File | Description |
|---|---|
| test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs | Removed an outdated test and added a CI skip condition to a test to improve performance on ADO |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs:1237
- [nitpick] The CI skip condition effectively removes this test from continuous integration. Please ensure that the test is executed in non-CI environments to maintain adequate test coverage and catch any regressions.
Skip.If(Environment.GetEnvironmentVariable("TF_BUILD") is not null,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove test that's no longer run since <7.4 has been dropped.