WIP: initial implementation of Edit-Content command #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
force-pushed
the
rkeithhill/impl-edit-content
branch
from
f8fc8fa to
d1f4cd0
Compare
rkeithhill
force-pushed
the
rkeithhill/impl-edit-content
branch
from
d1f4cd0 to
12318c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress but I wanted to show what I've got so far. There are plenty of design decisions to be made on this command. Right now it only edits files. Should it have an InputObject parameter? There are optimizations for loading smaller files completely into memory vs using a temp file for larger files, etc. Also, I wrote the original code ~6 years ago so there may be better ways in .NET now to do things.
The main thing I need to do now is to test this code.
Fix #19