Fix for Y2038 gettimeofday for Win32 builds #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is the second part of the fix for Y2038 issues, first part is on LibreSSL PowerShell/LibreSSL#30 , we need to override the definition of timeval from winsock2.h.
PR Context
OpenSSH uses gettimeofday from LibreSSL, OpenSSH and LibreSSL has been using the definition of winsock2.h https://learn.microsoft.com/en-us/windows/win32/api/winsock2/ns-winsock2-timeval that is signed integer, this made LibreSSL and OpenSSH prone to the Y2038 problem. As we modify the declaration of gettimeofday on LibreSSL we need to override the declaration of timeval in OpenSSH also to match the LibreSSL signature.
Note that if we made this change the version of LibreSSL with the fix has to be released at the same time or signatures will not match.