Downgrade vscode-languageclient to v8.1.0
#4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because v9.0.0 upped the VS Code requirement to v1.82.0, above our own current requirement (and also is _very_ new). Downgrading brings its minimum back to 1.67.0, below ours.
|
I'll manually run Dependabot after this merges and then tell it not to upgrade this. Again, we have to wait for Azure Data Studio to take in an engine upgrade, which for 1.82 will be a while. |
SydneyhSmith
approved these changes
Sep 29, 2023
andyleejordan
deleted the
andyleejordan/downgrade-vscode-languageclient
branch
|
Ok Dependabot now ignoring #4767 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because v9.0.0 upped the VS Code requirement to v1.82.0, above our own current requirement (and also is very new). Downgrading brings its minimum back to 1.67.0, below ours.
Resolves #4762.