Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LanguageClient Tracing Option #4902

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented Jan 25, 2024

PR Summary

Enables the native vscode-languageclient tracing option that allows all LSP activity to be viewed from the client in an output window.

Reference: https://code.visualstudio.com/api/language-extensions/language-server-extension-guide#logging-support-for-language-server

image

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@JustinGrote JustinGrote requested a review from a team January 25, 2024 19:40
@JustinGrote JustinGrote self-assigned this Jan 25, 2024
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/session.ts Outdated Show resolved Hide resolved
@JustinGrote JustinGrote requested a review from a team as a code owner January 25, 2024 19:59
@JustinGrote JustinGrote enabled auto-merge January 25, 2024 20:28
@JustinGrote JustinGrote disabled auto-merge January 25, 2024 20:30
Co-authored-by: Andy Jordan <[email protected]>

📄 Update Docs and instructions

Remove note about it being an unsupported option
@JustinGrote JustinGrote force-pushed the justingrote/feature/languageClient-trace branch from c2ea6d7 to d10e3c7 Compare January 25, 2024 20:32
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU

@andyleejordan andyleejordan added this pull request to the merge queue Jan 25, 2024
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Configuration labels Jan 25, 2024
Merged via the queue into main with commit 463407a Jan 25, 2024
7 checks passed
@andyleejordan andyleejordan deleted the justingrote/feature/languageClient-trace branch January 25, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Configuration Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants