Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Extension Setting Categories #5103

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented Nov 26, 2024

PR Summary

We have a lot of settings, so this organizes them into categories using the contributes sections feature of vscode. I applied some subjective "most commonly used" logic to the order of the categories and settings within the categories.

image

I did a check and it doesn't look like I missed any settings, they appear to all be there.
image
(what may not be clear is I switched branches between the two collections of package.json...)

@JustinGrote JustinGrote requested a review from Copilot November 26, 2024 19:50
@JustinGrote JustinGrote self-assigned this Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I love it. I used your same PowerShell snippet in your screenshot but ran it through Compare-Object, I think you're good! I tested this out and it's great.

@JustinGrote JustinGrote merged commit 23619a9 into main Nov 27, 2024
7 checks passed
@JustinGrote JustinGrote deleted the justingrote/feature/settingGroups branch November 27, 2024 20:49
@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants