Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase height of texteditor #25

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Increase height of texteditor #25

wants to merge 11 commits into from

Conversation

bajran
Copy link
Contributor

@bajran bajran commented Oct 15, 2019

-- Added the setsize function to increase the size of yaml and go editor

@netlify
Copy link

netlify bot commented Oct 15, 2019 •
edited
Loading

Deploy preview for compassionate-einstein-004585 ready!

Built with commit 4d12e7c

https://deploy-preview-25--compassionate-einstein-004585.netlify.com

@PrasadG193
Copy link
Owner

@bajran Please resolve the conflicts. Also, I can't see the "Convert" button in the preview link. Please fix that

@PrasadG193
Copy link
Owner

@bajran Please rebase your branch with master and fix the button issue

@PrasadG193
Copy link
Owner

@bajran please verify preview: https://deploy-preview-25--compassionate-einstein-004585.netlify.com/

@bajran
Copy link
Contributor Author

bajran commented Oct 21, 2019 •
edited
Loading

@bajran please verify preview: https://deploy-preview-25--compassionate-einstein-004585.netlify.com/

Did u removed codemirror from that ? did we miss something in ui, I am able to see 2 View Source button in current preview

@PrasadG193
Copy link
Owner

No. Please compare with master: https://yaml2go.prasadg.dev

PrasadG193
PrasadG193 reviewed Oct 21, 2019
View reviewed changes
frontend/index.js Outdated Show resolved Hide resolved
@PrasadG193
Copy link
Owner

Doesn't look correct: https://deploy-preview-25--compassionate-einstein-004585.netlify.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bajran @PrasadG193