Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Netflix): pause and showsmallimages issues #9049

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

iuriineves
Copy link
Contributor

Description

  • Set timestamps to 0 when the video is paused - setting it to null breaks the .setActivity() function, only updating the information when the video is running;
  • Set smallImageKey to null when showSmallImages is false - setting it to "" didn't remove the image.

Closes #9031.

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

(pausing)
image

(showSmallImages set to false)
image

- Fixed issue where pausing would not update the presence status correctly - setting the timestamp to null broke the presence
- Resolved problem with small images not displaying properly - setting the image url to "" wouldn't update the image

Closes PreMiD#9031
@theusaf theusaf requested a review from Timeraa January 2, 2025 01:44
@theusaf theusaf enabled auto-merge (squash) January 2, 2025 01:45
Timeraa

This comment was marked as outdated.

Timeraa
Timeraa previously requested changes Jan 2, 2025
Copy link
Member

@Timeraa Timeraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you want to not show a certain thing just remove its property from the setactivity, setting it to something invalid will just cause more issues

@iuriineves
Copy link
Contributor Author

When you want to not show a certain thing just remove its property from the setactivity, setting it to something invalid will just cause more issues

The way the activity is coded, it has to be set to null for some reason. When I was testing it, setting smallImageKey to an empty string didn't remove the image, but setting it to null did.

@Timeraa Timeraa requested review from theusaf and Bas950 January 3, 2025 03:38
@Timeraa
Copy link
Member

Timeraa commented Jan 3, 2025

When you want to not show a certain thing just remove its property from the setactivity, setting it to something invalid will just cause more issues

The way the activity is coded, it has to be set to null for some reason. When I was testing it, setting smallImageKey to an empty string didn't remove the image, but setting it to null did.

I pushed to the PR, look at what I changed, learn more about it here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax
image

@theusaf theusaf merged commit 6f85a65 into PreMiD:main Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Netflix | www.netflix.com - pausing doesn't update presence
4 participants