feat(Club Penguin Journey): Add support for current RoomId with Room display on Status. #9251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moyaimoment <[email protected]>
Signed-off-by: moyaimoment <[email protected]>
moyaimoment
changed the title
Signed-off-by: moyaimoment <[email protected]>
theusaf
requested changes
Feb 11, 2025
Comment on lines
5
to
20
| actualCode = ` | ||
| let roomIdLabel = document.createElement("p"); | ||
| roomIdLabel.setAttribute("id", "roomId"); | ||
| document.head.appendChild(roomIdLabel); | ||
|
|
||
| let repeatTimer = setInterval(function() { | ||
| const roomId = window.roomId; | ||
| if (roomId) { | ||
| roomIdLabel.textContent = roomId; | ||
| } | ||
| }, 100); | ||
| `, | ||
| script = document.createElement("script"); | ||
| script.setAttribute("id", "injectscript"); | ||
| script.textContent = actualCode; | ||
| (document.head || document.documentElement).appendChild(script); |
There was a problem hiding this comment.
You can probably use presence.getPageVariable rather than injecting a script
There was a problem hiding this comment.
Oh, I didn't realize that was something I could use. It works and I've implemented it, Thanks!
Signed-off-by: moyaimoment <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recently contacted the Club Penguin Journey staff and asked for a way to get the current roomId and they were able to add something in the for the Presence. This update adds support for getting and using these RoomIds. This is based off the old Club Penguin Rewritten presence.
If there is a better way to do it then let me know. 🤷♂️
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected