Updating the tests to be tolerant of the differences between Pydantic v1 and v2 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… v1 and v2 While we're in a mode where Cloud is still on v1, we need to make a few adjustments to how we compare the schemas.
chrisguidry
added a commit
to PrefectHQ/prefect
that referenced
this pull request
May 29, 2024
This corresponds with adjustments in PrefectHQ/compat-tests#23
chrisguidry
added a commit
to PrefectHQ/prefect
that referenced
this pull request
May 29, 2024
This corresponds with adjustments in PrefectHQ/compat-tests#23
jakekaplan
approved these changes
May 29, 2024
jakekaplan
reviewed
May 29, 2024
test_oss_cloud_api_compatibility.py
Outdated
| ) in oss_props[1].items(): | ||
| assert field_name in cloud_props[1] | ||
| ) in oss_props[1].values(): | ||
| print(endpoint, method, oss_name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're in a mode where Cloud is still on v1, we need to make a few
adjustments to how we compare the schemas.