Merge pull request #256 from PrefectHQ/replace-foreach-with-for-of

Replace forEach with for of for performance
PrefectHQ · Oct 20, 2023 · d7222b9 · d7222b9
2 parents 4c8745e + 8021e18
commit d7222b9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/factories/nodes.ts b/src/factories/nodes.ts
@@ -80,7 +80,7 @@ export async function nodesContainerFactory(runId: string) {
   }
 
   function setPositions(): void {
-    layout.forEach((position, nodeId) => {
+    for (const [nodeId, position] of layout) {
       const node = nodes.get(nodeId)
 
       if (!node) {
@@ -89,7 +89,7 @@ export async function nodesContainerFactory(runId: string) {
       }
 
       node.container.position = getActualPosition(position)
-    })
+    }
 
     container.emit('resized')
     container.emit('rendered')

diff --git a/src/workers/layouts/horizontal.ts b/src/workers/layouts/horizontal.ts
@@ -18,9 +18,9 @@ function getHorizontalDependencyLayout({ data, horizontalSettings }: ClientLayou
   const scale = horizontalScaleFactory(horizontalSettings)
   const layout: HorizontalLayout = new Map()
 
-  data.nodes.forEach((node, nodeId) => {
+  for (const [nodeId] of data.nodes) {
     layout.set(nodeId, scale(levels.get(nodeId)!))
-  })
+  }
 
   return layout
 }
@@ -29,9 +29,9 @@ function getHorizontalTimeLayout({ data, horizontalSettings }: ClientLayoutMessa
   const scale = horizontalScaleFactory(horizontalSettings)
   const layout: HorizontalLayout = new Map()
 
-  data.nodes.forEach((node, nodeId) => {
+  for (const [nodeId, node] of data.nodes) {
     layout.set(nodeId, scale(node.start_time))
-  })
+  }
 
   return layout
 }

diff --git a/src/workers/layouts/vertical.ts b/src/workers/layouts/vertical.ts
@@ -16,9 +16,9 @@ function getVerticalWaterfallLayout(message: ClientLayoutMessage): VerticalLayou
 
   let index = 0
 
-  message.data.nodes.forEach((node, nodeId) => {
+  for (const [nodeId] of message.data.nodes) {
     layout.set(nodeId, index++)
-  })
+  }
 
   return layout
 }

diff --git a/src/workers/runGraph.worker.ts b/src/workers/runGraph.worker.ts
@@ -28,7 +28,7 @@ function handleLayoutMessage(message: ClientLayoutMessage): void {
   const vertical = getVerticalLayout(message, horizontal)
   const layout: NodeLayoutResponse = new Map()
 
-  data.nodes.forEach((node, nodeId) => {
+  for (const [nodeId, node] of data.nodes) {
     const x = horizontal.get(nodeId)
     const y = vertical.get(nodeId)
 
@@ -46,7 +46,7 @@ function handleLayoutMessage(message: ClientLayoutMessage): void {
       x,
       y,
     })
-  })
+  }
 
   post({
     type: 'layout',