Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Allow cloning with custom git depth #40

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Allow cloning with custom git depth #40

merged 6 commits into from
Apr 19, 2024

Conversation

sgsfak
Copy link
Contributor

@sgsfak sgsfak commented Mar 25, 2024

Closes #39

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.

@sgsfak sgsfak requested a review from a team as a code owner March 25, 2024 08:15
desertaxle
desertaxle suggested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sgsfak! I have one suggestion on the interface, but otherwise, the implementation looks good!

prefect_gitlab/repositories.py Outdated Show resolved Hide resolved
prefect_gitlab/repositories.py Outdated Show resolved Hide resolved
tests/test_repositories.py Outdated Show resolved Hide resolved
@sgsfak sgsfak requested a review from desertaxle March 28, 2024 17:31
desertaxle
desertaxle suggested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good! Just a couple more nits, and this should be ready to merge!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sgsfak @desertaxle
Apply suggestions from code review
4483ed6 
Co-authored-by: Alexander Streed <[email protected]>
@sgsfak sgsfak requested a review from desertaxle April 19, 2024 06:14
desertaxle
desertaxle approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desertaxle desertaxle merged commit 58bc8c7 into PrefectHQ:main Apr 19, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desertaxle desertaxle desertaxle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow cloning with custom git depth
2 participants
@sgsfak @desertaxle