Feature: VariablesTable, VariablesDelete, filters, bulk and count routes
#1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znicholasbrown
requested review from
pleek91,
zhen0 and
brandonreid
as code owners
✅ Deploy Preview for prefect-ui-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pleek91
approved these changes
Mar 31, 2023
Comment on lines
+33
to
+34
| const variableDeletePromises = variableIds.map(api.variables.deleteVariable) | ||
| await Promise.all(variableDeletePromises) |
There was a problem hiding this comment.
Since this feature is being actively built. Any chance we can get an api endpoint for this?
There was a problem hiding this comment.
@jakekaplan and i talked about this yesterday (great minds etc) - we can but we don't really need it since there's a fairly low cap on the number of variables one can create
Comment on lines
+128
to
+143
| const selectedVariables = ref<string[]>([]) | ||
| const selectAllVariables = (allVariablesSelected: CheckboxModel): string[] => { | ||
| if (allVariablesSelected) { | ||
| return selectedVariables.value = [...variables.value.map(variable => variable.id)] | ||
| } | ||
| return selectedVariables.value = [] | ||
| } | ||
|
|
||
| const model = computed({ | ||
| get() { | ||
| return selectedVariables.value.length === variables.value.length | ||
| }, | ||
| set(value: boolean) { | ||
| selectAllVariables(value) | ||
| }, | ||
| }) |
There was a problem hiding this comment.
We should make a select all component for this. Takes an array v-model and an array of all the possible values.
There was a problem hiding this comment.
Oh yea good thought, we're doing this in a few places. I'll open a ticket 👍🏻
This was referenced Mar 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
VariablesTablecomponent - primary variables display, a paginated tableVariablesDeletecomponent - used for handling bulk deletes by passing a list of variable ids/filterand/countapi services - both WIP, no backend work has been merged for these yet (though I believe it's begun); these are based on chats with @jakekaplan