Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle execution capabilities to Runner #17192

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Feb 19, 2025

This PR uses the utilities introduced in #17178 to outfit the Runner class to kick off and monitor the execution of a bundle. The Runner can handle cancellation and crash detection for flow runs initiated via bundle the same as if execution was kicked off by a normally scheduled run.

The execute_bundle method duplicates some logic because I want to move the Runner control flow towards one where we kick off subprocess via multiprocessing rather than subprocess. I think that flow is substantially easier to understand and should be possible with the run_flow_in_subprocess utility in a later PR.

Related to #17194

Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #17192 will not alter performance

Comparing runner-execute-bundle (bbabdfb) with main (a476000)

Summary

✅ 2 untouched benchmarks

@desertaxle desertaxle marked this pull request as ready for review February 19, 2025 16:40
Base automatically changed from experimental-bundles to main February 19, 2025 16:53
@desertaxle desertaxle force-pushed the runner-execute-bundle branch from e9f647c to d2a69fb Compare February 19, 2025 16:54
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo!

@desertaxle desertaxle merged commit 59c5526 into main Feb 19, 2025
46 checks passed
@desertaxle desertaxle deleted the runner-execute-bundle branch February 19, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants